fix(engine): implement llm.Provider via contract aliases#88
Merged
Conversation
Re-export host-facing DTOs from hawk-core-contracts/llm, assert *Engine implements llm.Provider and *Stream implements EventStreamer, return EventStreamer from Stream with proper nil-interface handling, and document the llm dependency on the ecosystem boundary.
3 tasks
CI resolves modules without go.work; pin the feature commit that provides EventStreamer, CheckStatus, and the aligned CatalogHealth/Preflight types.
Use the published main tip so CI can resolve EventStreamer and aligned host types without feature-branch pseudo-version unshallow issues.
Use the tagged host-port alignment release so CI avoids pseudo-version unshallow failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hawk-core-contracts/llmas engine type aliases.*Engineimplementsllm.Provider,*StreamimplementsEventStreamer.Engine.StreamreturnsEventStreamerwith correct nil-interface handling.Depends on
Local
go.workcontinues to replace contracts for development. After contracts lands, consumers can pin the released module version as usual.Test plan
go test ./engine/...go test ./...bash scripts/check-ecosystem-boundaries.sh